Various improvements, mostly having to do with large files. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dworkin
commented
Mar 26, 2019
•
dworkin
commented
- Upgrade integrated WebDAV client from Itay Sagui to 1.1.4, to get partial up/download functionality.
- Include explicit GPLv3 license file.
- Fix some minor path-handling bugs.
- Use chunked mode to upload files.
- Disable 4G limit check to allow up/download of large files.
- Use streaming upload when FlushMode == FlushAtWrite.
- Use byte ranges for read requests (don't download and cache the entire file).
The license was previously only mentioned in the About dialog.
Move byte array handling to the wrapper.
And keep adding to the content stream when FlushMode == FlushAtWrite.
And to avoid a crash with WinFsp 2019.1.
Save memory by not buffering the entire file, but only the chunk currently written.
Change WebDavClient2.DownloadPartial to return a byte array instead of a stream.
Let DavFS.Read return STATUS_END_OF_FILE when trying to read beyond the end of a file that is still being uploaded.
And ensure that the hyperlink works in the dialog box when the WinFSP service cannot be started.
|
Thanks for the huge contribution. |
To get the fix for reading files >= 4G.
This avoids using a separate PUT to create the file (which causes davrods to create extra revisions), and ensures that early reads are intercepted by CFN.PendingUpload (which causes problems with a mod_dav backend).
Tested with Apache mod_dav and davrods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.