Added RA configuration for some antennas, and modified antenna of NFE #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where the F-DA Direct Antenna Feed's `Omni-directional` would have negative values in the Stock environment.
|
|
Aebestach
changed the title
Aebestach
changed the title
|
An antenna diameter of less than 0.1 meters works fine, it's just a display error in the tooltip. |
|
Can this display problem be fixed? |
|
Probably. |
|
The issue is that if an antenna is small enough, when RA goes to generate the tooltip (starting from the lowest frequency) it calculates a gain less than 5 dbi and assumes the antenna is an omni, without bothering to check further. A quick fix would be to just check from the highest frequency first instead so it sees a gain above 5 dbi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%antennaDiameterof theF-DA Direct Antenna Feedis less than 0.1, it will degenerate to the%referenceGainmode, and the gain may be negative. I don’t know whether it is due to the change in logic after the RA update or the change in the NFE configuration.