Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] 약속 - 약속 수정/삭제 리팩토링 #46

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

ahhyun1015
Copy link
Contributor

PR Type ⚙️

  • Refactor: 프로덕션 코드 리팩토링
  • Comment: 필요한 주석 추가 및 변경

What is this PR? 📝

Related Issue Number


Changes

  • 약속 수정 페이지에 대한 제약조건 함수를 만들었어요
  • 약속 삭제 페이지 코드 구성을 알맞게 변경했어요

Other information 🔥

  • 리뷰하면서 이런 점들을 참고해주세요!

@ahhyun1015 ahhyun1015 requested review from anjiniii and slr-09 January 13, 2024 12:35
@ahhyun1015 ahhyun1015 self-assigned this Jan 13, 2024
@ahhyun1015 ahhyun1015 added 🐱 아현 담당자: 아현 🛠️ refactor 리팩토링 / 코드 구조를 변경 labels Jan 13, 2024
@ahhyun1015 ahhyun1015 linked an issue Jan 13, 2024 that may be closed by this pull request
5 tasks
@ahhyun1015 ahhyun1015 changed the title [PR] 약속 - 약속 수정/삭제 [PR] 약속 - 약속 수정/삭제 리팩토링 Jan 13, 2024
Comment on lines +327 to +344
// 약속 수정페이지 설정
func setupEditPlanPage(_ viewController: MakePlanViewController) {
viewController.titleLabel.text = "약속 수정하기"

viewController.planNameTextField.text = planTitle.text
viewController.planStartDateField.text = sendDate[0].replacingOccurrences(of: "-", with: ". ")
viewController.planStartDateField.textColor = UIColor.textDisabled
viewController.calendarButton.isEnabled = false

viewController.cautionLabel.text = "약속 기간은 수정할 수 없습니다."
viewController.cautionLabel.textColor = UIColor.textDisabled
viewController.cautionImage.isHidden = true

viewController.planStartDateField.isUserInteractionEnabled = false
viewController.makeButton.setTitle("수정", for: .normal)
viewController.planId = planId
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 이렇게 뺀 건 좋은 것 같아여!
그런데 어쩌다가 이렇게 nextVC에 설정해야할 내용이 많아진건가요..??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우 이게 뭐죠

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오우 이건 원래 있던 설정들인데 따로 함수화하면 깔끔해 보일것같아서 함수화를 해놓은거랍니다~~

@ahhyun1015 ahhyun1015 merged commit b194832 into develop Jan 21, 2024
@ahhyun1015 ahhyun1015 deleted the refactof/plan-edit-del branch January 21, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐱 아현 담당자: 아현 🛠️ refactor 리팩토링 / 코드 구조를 변경
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠️ Refactoring: 약속
3 participants