WIP: Add option to deploy Runtimeclass automatically #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Schmidt <[email protected]>
Signed-off-by: Max Schmidt <[email protected]>
Signed-off-by: Max Schmidt <[email protected]>
Signed-off-by: Max Schmidt <[email protected]>
Signed-off-by: Max Schmidt <[email protected]>
mschmidt291
changed the title
Signed-off-by: Max Schmidt <[email protected]>
|
@mschmidt291 What is still missing here to merge it? |
This PR only creates a Runtimeclass for crun, but it makes more sense to allow dynamic runtimeclass creation and not only for crun. |
|
I think this will be obsolete with the implementation of #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #6
This PR adds
support for creating the runtimeclass automatically
Adds tests for job reconciler testing the runtimeclass is successfully created
adding "CREATE_RUNTIME_CLASS" to the Helm chart (false per default)
The docker-build-push github action is now only running on merges/commits to the main branch.
a new test pipeline is running on PullRequests executing ginkgo tests