feat #1217: Open side panel when new node is added #1563
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
=======================================
Coverage ? 79.87%
Complexity ? 272
=======================================
Files ? 276
Lines ? 7845
Branches ? 1539
=======================================
Hits ? 6266
Misses ? 1467
Partials ? 112 ☔ View full report in Codecov by Sentry. |
| const result = props.vizNode.data.path | ||
| ? findVisualizationNode(controller.getGraph(), props.vizNode.data.path) | ||
| : null; | ||
| controller.fireEvent(SELECTION_EVENT, [result?.getNextNode()?.id]); |
There was a problem hiding this comment.
There are a few cases in which getNextNode doesn't yield the desired node:
- When adding a step in
from - Preprending a step from any given node
I'll try to check if we can get the new node id directly.
There was a problem hiding this comment.
Thanks, I will wait for your changes in lordrip@3d668cd before adding more capabilities
There was a problem hiding this comment.
- several cases are not working:
- When adding a step after the first element (it is called "add step" in this case), the config panel is closing
- When prepending a step, the select node is not the new node but the one on which we prepended
- When adding a step after the first element (it is called "add step" in this case), the config panel is closing
which I guess are linked to comment here #1563 (comment)
No description provided.