-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat #1217: Open side panel when new node is added #1563
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
=======================================
Coverage ? 79.87%
Complexity ? 272
=======================================
Files ? 276
Lines ? 7845
Branches ? 1539
=======================================
Hits ? 6266
Misses ? 1467
Partials ? 112 ☔ View full report in Codecov by Sentry. |
const result = props.vizNode.data.path | ||
? findVisualizationNode(controller.getGraph(), props.vizNode.data.path) | ||
: null; | ||
controller.fireEvent(SELECTION_EVENT, [result?.getNextNode()?.id]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few cases in which getNextNode
doesn't yield the desired node:
- When adding a step in
from
- Preprending a step from any given node
I'll try to check if we can get the new node id directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will wait for your changes in lordrip@3d668cd before adding more capabilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- several cases are not working:
which I guess are linked to comment here #1563 (comment)
No description provided.