Feature/people overhaul ux improvements

API.Tests/API.Tests.csproj

@@ -29,7 +29,6 @@
     <ItemGroup>
         <Folder Include="Services\Test Data\ArchiveService\ComicInfos" />
         <Folder Include="Services\Test Data\ImageService\Covers\" />
-        <Folder Include="Services\Test Data\ScannerService\Manga" />
     </ItemGroup>
 
     <ItemGroup>

API.Tests/Extensions/QueryableExtensionsTests.cs

@@ -126,28 +126,45 @@ public void RestrictAgainstAgeRestriction_Tag_ShouldRestrictEverythingAboveTeen(
     [InlineData(false, 1)]
     public void RestrictAgainstAgeRestriction_Person_ShouldRestrictEverythingAboveTeen(bool includeUnknowns, int expectedCount)
     {
-        var items = new List<Person>()
+        // Arrange
+        var items = new List<Person>
         {
-            new PersonBuilder("Test", PersonRole.Character)
-                .WithSeriesMetadata(new SeriesMetadataBuilder().WithAgeRating(AgeRating.Teen).Build())
-                .Build(),
-            new PersonBuilder("Test", PersonRole.Character)
-                .WithSeriesMetadata(new SeriesMetadataBuilder().WithAgeRating(AgeRating.Unknown).Build())
-                .WithSeriesMetadata(new SeriesMetadataBuilder().WithAgeRating(AgeRating.Teen).Build())
-                .Build(),
-            new PersonBuilder("Test", PersonRole.Character)
-                .WithSeriesMetadata(new SeriesMetadataBuilder().WithAgeRating(AgeRating.X18Plus).Build())
-                .Build(),
+            CreatePersonWithSeriesMetadata("Test1", AgeRating.Teen),
+            CreatePersonWithSeriesMetadata("Test2", AgeRating.Unknown, AgeRating.Teen),
+            CreatePersonWithSeriesMetadata("Test3", AgeRating.X18Plus)
         };
 
-        var filtered = items.AsQueryable().RestrictAgainstAgeRestriction(new AgeRestriction()
+        var ageRestriction = new AgeRestriction
         {
             AgeRating = AgeRating.Teen,
             IncludeUnknowns = includeUnknowns
-        });
+        };
+
+        // Act
+        var filtered = items.AsQueryable().RestrictAgainstAgeRestriction(ageRestriction);
+
+        // Assert
         Assert.Equal(expectedCount, filtered.Count());
     }
 
+    private static Person CreatePersonWithSeriesMetadata(string name, params AgeRating[] ageRatings)
+    {
+        var person = new PersonBuilder(name).Build();
+
+        foreach (var ageRating in ageRatings)
+        {
+            var seriesMetadata = new SeriesMetadataBuilder().WithAgeRating(ageRating).Build();
+            person.SeriesMetadataPeople.Add(new SeriesMetadataPeople
+            {
+                SeriesMetadata = seriesMetadata,
+                Person = person,
+                Role = PersonRole.Character // Role is now part of the relationship
+            });
+        }
+
+        return person;
+    }
+
     [Theory]
     [InlineData(true, 2)]
     [InlineData(false, 1)]

API.Tests/Extensions/SeriesExtensionsTests.cs

@@ -185,6 +185,35 @@ public void GetCoverImage_JustVolumes()
         Assert.Equal("Volume 1 Chapter 1", series.GetCoverImage());
     }
 
+    [Fact]
+    public void GetCoverImage_JustVolumes_ButVolume0()
+    {
+        var series = new SeriesBuilder("Test 1")
+            .WithFormat(MangaFormat.Archive)
+
+            .WithVolume(new VolumeBuilder("0")
+                .WithName("Volume 0")
+                .WithChapter(new ChapterBuilder(Parser.DefaultChapter)
+                    .WithCoverImage("Volume 0")
+                    .Build())
+                .Build())
+
+            .WithVolume(new VolumeBuilder("1")
+                .WithName("Volume 1")
+                .WithChapter(new ChapterBuilder(Parser.DefaultChapter)
+                    .WithCoverImage("Volume 1")
+                    .Build())
+                .Build())
+            .Build();
+
+        foreach (var vol in series.Volumes)
+        {
+            vol.CoverImage = vol.Chapters.MinBy(x => x.SortOrder, ChapterSortComparerDefaultFirst.Default)?.CoverImage;
+        }
+
+        Assert.Equal("Volume 1", series.GetCoverImage());
+    }
+
     [Fact]
     public void GetCoverImage_JustSpecials_WithDecimal()
     {