Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using new ScrapedDuck generic event data #909

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hamster007Github
Copy link
Contributor

@hamster007Github hamster007Github commented Aug 23, 2024

Using new additional generic event data to also notify about events != spotlight-hour and community day.

Description

check new extraData -> generic block in event data

Motivation and Context

Enable PoracleJS to notify about start/end of all kind of events, which change pokemon or field-research pool. Before we only check by event type (spotlight-hour and community-day)

How Has This Been Tested?

Local debugging. Filtered event lists contain expected events.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jfberry
Copy link
Collaborator

jfberry commented Aug 30, 2024

No longer required

@jfberry jfberry closed this Aug 30, 2024
@hamster007Github
Copy link
Contributor Author

The PR is still needed / an addition. Without, the new generic data is not checked. I already changed back the url to original repo.

@jfberry jfberry reopened this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants