Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jerry Hicks #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jhicks-camgian
Copy link

Trying to make cross-compiling for our Linux Cortex-A9 ARM a bit easier. Please review.

I think it might be better to create the riffa_driver.h file from a riffa_driver.h.in template (as opposed to in-place sed edits). In these mods I made it all work using conditionals but did not consider if that broke anything out of the driver subdirectory.

We like builds that can run out-of-tree so the sources can remain immutable and compile outputs can land in a different directory (on a read-only share, etc) but that's really only a small matter of personal taste.

Thanks for RIFFA! We are really having a blast with it.

Note: The install target still doesn't work for cross-compiling.
      Be careful to not use the install targets unless you are
      host-compiling.
@drichmond
Copy link
Collaborator

First pass, this looks good. When I cycle back around to RIFFA, I will review it more thoroughly.

I may need you to retarget it -- for example, to the 2.3.0 branch. TBD>

@jhicks-camgian
Copy link
Author

Thanks Dustin,

Let me know and I'll be happy to advance with you. Might also have a change to go into my PR, will be looking at it over the next couple of days.


From: Dustin Richmond [email protected]
Sent: Friday, September 16, 2016 12:20:43 PM
To: drichmond/riffa
Cc: Jerry Hicks; Author
Subject: Re: [drichmond/riffa] Jerry Hicks (#16)

First pass, this looks good. When I cycle back around to RIFFA, I will review it more thoroughly.

I may need you to retarget it -- for example, to the 2.3.0 branch. TBD>

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/16#issuecomment-247657515, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMk5CvL1Z-uweLXJayz4t59_OCoynjRFks5qqs_rgaJpZM4J55xb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants