feat(cli): support CLI completion (#2017)

enables the underlying cobra CLI completion scripts.

supported shells:
* Bash
* Zsh
* Fish
* PowerShell

this replaces (and un-hides) the previously existing tendermint
completion command that only supported bash & zsh.

see `kava completion <shell> --help` for specifics

CHANGELOG.md

@@ -70,6 +70,7 @@ For more details see the [IAVL V1 migration guide](/migrate/v0_26/iavl-v1.md).
     a state similar to if the data has been pruned.
     - An IAVL v1 reference node is saved at the upgrade height pointing to the version 1 data so app
     data for the upgrade version can be properly loaded.
+- (cli) [#2017] Support CLI `completion` for bash, zsh, fish, & powershell.
 
 ### Improvements
 - (deps) [#1988] Bump cometbft to v0.37.9-kava.1
@@ -398,6 +399,7 @@ the [changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.38.4/CHANGELOG.md).
 
 [ethermint#82]: https://github.com/Kava-Labs/ethermint/pull/82
 [ethermint#77]: https://github.com/Kava-Labs/ethermint/pull/77
+[#2017]: https://github.com/Kava-Labs/kava/pull/2017
 [#1988]: https://github.com/Kava-Labs/kava/pull/1988
 [#1973]: https://github.com/Kava-Labs/kava/pull/1973
 [#1967]: https://github.com/Kava-Labs/kava/pull/1967

cmd/kava/cmd/root.go

@@ -7,7 +7,6 @@ import (
 
 	dbm "github.com/cometbft/cometbft-db"
 	tmcfg "github.com/cometbft/cometbft/config"
-	tmcli "github.com/cometbft/cometbft/libs/cli"
 	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/client/config"
 	"github.com/cosmos/cosmos-sdk/client/debug"
@@ -114,8 +113,6 @@ func addSubCmds(rootCmd *cobra.Command, encodingConfig params.EncodingConfig, de
 		genutilcli.GenTxCmd(app.ModuleBasics, encodingConfig.TxConfig, banktypes.GenesisBalancesIterator{}, defaultNodeHome),
 		genutilcli.ValidateGenesisCmd(app.ModuleBasics),
 		AddGenesisAccountCmd(defaultNodeHome),
-		tmcli.NewCompletionCmd(rootCmd, true), // TODO add other shells, drop tmcli dependency, unhide?
-		// testnetCmd(app.ModuleBasics, banktypes.GenesisBalancesIterator{}), // TODO add
 		debug.Cmd(),
 		config.Cmd(),
 	)