chore(deps): Update Go, cometbft, rocksdb dependencies #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drklee3
changed the title
DracoLi
reviewed
Nov 4, 2024
|
i believe a rebase of this branch onto |
This also updates Go to 1.22 since CometBFT v0.37.12 requires 1.22+
This fork updates dependencies so it uses protobuf >= v.1.33.0 to address GHSA-8r3f-844c-mc37
Our modifications on cometbft-db were to update RocksDB from v1.8.6 to v1.8.13 and to create the RocksDB directory if it doesn't exist. These modifications are no longer necessary: cometbft-db v0.9.5 updates support for RocksDB 9.2.1 Kava uses opendb which handles the creation of RocksDB directories
More relevant issue for the reason of this replacment
This matches the replacement of Cosmos SDK in v0.47.x
To match the main go.mod
The rapid package only used by Cosmos SDK tests so it shouldn't affect kava. However, just including the replace and documenting it so it's clear that we have verified the use of the package and not omitted because we missed it.
drklee3
force-pushed
the
dl-v0.27.x/dependencies
branch
from
7d1a954
to
6873cf4
Compare
drklee3
requested review from
rhuairahrighairidh,
karzak,
nddeluca,
evgeniy-scherbina,
sesheffield,
boodyvo and
lbayas
as code owners
nddeluca
reviewed
Nov 4, 2024
nddeluca
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cometbftv0.37.9-kava.1->v0.37.13-kava.1cometbft-dbv0.9.1-kava.2->v0.9.5(upstream)v9.2.1, our RocksDB version modificationv1.8.6->v1.8.13no longer neededopendbmodulekava/opendbmodule depends on compatible versions ofcometbft-dbandgrocksdbso it doesn't need to be tagged with a new versioninformalsystems/goleveldbfork to match cometbft-db1.21->1.22v8.10.0->v9.3.1vialinxGnu/[email protected]go.modfiles, e.g. e2e-ibckava/[email protected]docker imageChecklist