Add feature for just the urlencode builtin #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, I don't have to pull in a bunch of other dependencies that I don't need, but can still have the urlencode filter which I do need.
|
@Keats any chance you can take a look at this PR? |
Keats
reviewed
Feb 28, 2022
Cargo.toml
Outdated
| @@ -43,7 +43,8 @@ tempfile = "3" | |||
|
|
|||
| [features] | |||
| default = ["builtins"] | |||
| builtins = ["slug", "percent-encoding", "humansize", "chrono", "chrono-tz", "rand"] | |||
| builtins = ["builtins_urlencode", "slug", "humansize", "chrono", "chrono-tz", "rand"] | |||
| builtins_urlencode = ["percent-encoding"] | |||
There was a problem hiding this comment.
can you just name the feature urlencode?
There was a problem hiding this comment.
yes, I renamed the feature to just urlencode
|
cool, I'll merge it with #711 when both are ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, I don't have to pull in a bunch of other dependencies that I don't need, but can still have the urlencode filter which I do need.