implement a faster sort #803
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
requested changes
Feb 14, 2023
| Ok(()) | ||
| }) | ||
| .collect(); | ||
| misfits?; |
There was a problem hiding this comment.
Better to put ? after the collect.
| return Ok(a.cmp(&b)); | ||
| } | ||
| } | ||
| Err(Error::msg(format!("{a} cannot be sorted"))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using unstable_sort without allocating a copy of the object.
it checks if the pointer (json path) is available for each entry, and if the type (string,array,number) is identical.
Additionally the errormessage is more detailed.
I didn't benchmark yet.