Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Make Context a user-implementable Trait #829

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Draft: Make Context a user-implementable Trait #829

wants to merge 9 commits into from

Commits on May 12, 2023

  1. Make UserContext a Trait

    @fabianfreyer
    fabianfreyer committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d3ea2de View commit details
    Browse the repository at this point in the history

  2. Move ContextProvider to context.rs

    @fabianfreyer
    fabianfreyer committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0037bfe View commit details
    Browse the repository at this point in the history

  3. Make context generic everywhere

    @fabianfreyer
    fabianfreyer committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c52158b View commit details
    Browse the repository at this point in the history

  4. Make ContextProvider easier to implement 

    Provide a default find_value_by_dotted_pointer implementation based on find_value.
    @fabianfreyer
    fabianfreyer committed May 12, 2023
    Configuration menu
    Copy the full SHA
    ac9c466 View commit details
    Browse the repository at this point in the history

  5. Document ContextProvider

    @fabianfreyer
    fabianfreyer committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2f12a23 View commit details
    Browse the repository at this point in the history

  6. Implement ContextProvider::insert using try_insert

    @fabianfreyer
    fabianfreyer committed May 12, 2023
    Configuration menu
    Copy the full SHA
    59babf2 View commit details
    Browse the repository at this point in the history

  7. Expose ContextProvider externally

    @fabianfreyer
    fabianfreyer committed May 12, 2023
    Configuration menu
    Copy the full SHA
    71eeed2 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Make ContextProvider return Cows 

    This allows implementors to return owned values.
    @fabianfreyer
    fabianfreyer committed May 13, 2023
    Configuration menu
    Copy the full SHA
    249b45d View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Add ContextProvider example

    @fabianfreyer
    fabianfreyer committed May 15, 2023
    Configuration menu
    Copy the full SHA
    6cd9cdc View commit details
    Browse the repository at this point in the history