Add pad filter #921
Open
Add pad filter #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, just saw #900 (comment). Is it worth opening a PR over at https://github.com/Keats/tera2 instead or is that premature? |
|
Filters are not implemented yet in tera2 but I would wait. I did work a bit on it yesterday and i'm seeing the light regarding that. A dim light still but it's getting there. |
|
Glad to hear it! Excited for tera2. Would you be interested in adding this sort of filter when the time comes for tera2 though? I also have some thoughts about some filters that should be potentially removed/deprecated in the next breaking version... |
|
Some will be yes, i'll create a separate crate for non-basic filters/functions so i can do breaking change in that without issues. This one should be able to be added in the crate itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new filter called
padwhich pads a given string to a given length with a given fill character (defaults to a space).