Create pdf2txt.py #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liadmagen
added
enhancement
|
The packages (textract, PyPDF2) should be added at least to the pipenv, to be installed for new users. Textract gives hard time installing, sometimes (at least on windows), because of 3rd party packages installations for OCR. Maybe using the underlying packages (i.e. PDFminer) can ease that pain, |
liadmagen
requested changes
Oct 13, 2018
There was a problem hiding this comment.
Very nice, thank you for your contribution!
In order to make it work, it needs to actually take the files from the data/raw folder.
Consider turning it into a set of functions that receive as a parameter the folder path and the destination path, and recursively go over it, convert the pdf to text, and saves the result into the destination folder.
liadmagen
added
invalid
|
Oka will ameliorate soon
…On Sat, 13 Oct 2018 at 14:49, Liad ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Very nice, thank you for your contribution!
In order to make it work, it needs to actually take the files from the
data/raw folder.
Consider turning it into a set of functions that receive as a parameter
the folder path and the destination path, and recursively go over it,
convert the pdf to text, and saves the result into the destination folder.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX3zzQ50m7VcKqhr_k9OMgftYdYe8_Xpks5ukbAwgaJpZM4XL413>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a script as per the requirment