-
Notifications
You must be signed in to change notification settings - Fork 114
Commit
This updates both gqlparser and gqlgen dependencies. This was prompted by an error report in gqlparser. gqlparser also preserves comments now, so some test cases might need tweaking here. Per @tduong2049 in vektah/gqlparser#269 ### What happened? > I am using [genqlient](https://github.com/Khan/genqlient/) to generate GraphQL operations into Go code. It uses gqlparser to validate a provided graph before generating code. > In this case, I am using a supergraph composed from multiple subgraphs via Rover CLI. > Prior to [v2.5.2](https://github.com/vektah/gqlparser/releases/tag/v2.5.2), gqlparser parses the supergraph and returns no errors. > Upon upgrading to v2.5.2+, I get the following error when running `go run github.com/Khan/genqlient`: > `invalid schema: Argument extension for directive join__type cannot be null.` > Possibly related to #258? ### What did you expect? No parsing errors when running: `go run github.com/Khan/genqlient` on a supergraph. However, a validation error is returned when parsing `@join__type` directives. ### Minimal graphql.schema and models to reproduce ``` type AircraftManufacturer @join__type(graph: AIRCRAFT, key: "uuid") { uuid: ID! name: String! } ``` Signed-off-by: Steve Coffman <[email protected]> --------- Signed-off-by: Steve Coffman <[email protected]>
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.