Hiding "Label All Tasks" button #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the diff is really hard to view: I added "display:none" to the |
dat-boris
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
LGTM! Thanks for this css surgery to put in this fix - and explaining the css that is added. This is a good temporary fix, and a good motivation for us to upgrade to Label Studio latest version 😄
To be careful I validated what will be the impact of the class hiding.
document.getElementsByClassName("dm-button_look_primary")
I see 3 elements that is affected on the page here, and looks like all other primary CTA are with different classname (e.g. the "Submit" button is different). So this should be good as a temporary fix!
I have a quick question around deploy process - will DM on slack for that!
The default choice is “Label All Tasks” rather than “Label Tasks As Displayed”, which is really confusing when you’re on a tab with your selected tasks (most common labeling setup). With our current setup this code is in the DataManager repo, which we haven’t forked (and is deprecated). Once we update to new version of label studio this will all be in one repo but for now gonna do a hack and just hide the button. Labellers will be able to just click on a task in their tab to get started. Issue: https://khanacademy.atlassian.net/browse/DI-1500 Test plan: - ran label studio locally, created a project, imported a task, confirmed button is gone (see screenshot)
lizfaubell
force-pushed
the
remove-label-tasks-button-di-1500
branch
from
804f6a8
to
69ec993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The default choice is “Label All Tasks” rather than “Label Tasks As Displayed”, which is really confusing when you’re on a tab with your selected tasks (most common labeling setup). With our current setup this code is in the DataManager repo, which we haven’t forked (and is deprecated). Once we update to new version of label studio this will all be in one repo but for now gonna do a hack and just hide the button. Labellers will be able to just click on a task in their tab to get started.
Issue: https://khanacademy.atlassian.net/browse/DI-1500
Test plan: