Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Locked Figure Labels] Util function to generate spoken math + use it within Locked Point aria labels #1839

Merged
merged 13 commits into from
Nov 14, 2024
Merged

[Locked Figure Labels] Util function to generate spoken math + use it within Locked Point aria labels #1839

merged 13 commits into from
Nov 14, 2024
+170 −14

Commits on Nov 8, 2024

  1. [Locked Figure Labels] Util function to generate spoken math + use it… 

    … within Locked Point aria labels
    @nishasy
    nishasy committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    096a79d View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Use SimpleMarkdown parser to make sure dollar signs are parsed correctly

    @nishasy
    nishasy committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a3bef8a View commit details
    Browse the repository at this point in the history

  2. Add pure markdown as a dependency

    @nishasy
    nishasy committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    144b937 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Add TODO comment

    @nishasy
    nishasy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d00f96d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into spoken-aria-labels

    @nishasy
    nishasy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4fc07d8 View commit details
    Browse the repository at this point in the history

  3. Add more tests. Fix null nodes erroring out.

    @nishasy
    nishasy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d2139d6 View commit details
    Browse the repository at this point in the history

  4. changeset

    @nishasy
    nishasy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    007dbfa View commit details
    Browse the repository at this point in the history

  5. PR feedback: mock promise in test, update comment about autogenerated… 

    … label, update type on condenseTextNodes params
    @nishasy
    nishasy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8872044 View commit details
    Browse the repository at this point in the history

  6. handle race condition in locked point settings race condition

    @nishasy
    nishasy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7916eca View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Only run the getPrepopulatedAriaLabel async function when the button … 

    …is clicked rather when the props are changed
    @nishasy
    nishasy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    44cc790 View commit details
    Browse the repository at this point in the history

  2. Add loading state (for cases when the whole HTTP fetch needs to happen)

    @nishasy
    nishasy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2662370 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into spoken-aria-labels

    @nishasy
    nishasy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fc8c21d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into spoken-aria-labels

    @nishasy
    nishasy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    af82ae2 View commit details
    Browse the repository at this point in the history