[EXPERIMENT] WB-1588: Dropdowns + Cell prototype #3315
node-ci-pr.yml
on: pull_request
Matrix: Prime node_modules cache for primary configuration
Matrix: Check for .changeset entries for all changed files
Matrix: Publish npm snapshot
Matrix: Check build sizes
Matrix: Lint
Matrix: Test
Annotations
20 errors and 5 warnings
Check for .changeset entries for all changed files (ubuntu-latest, 16.x)
Changeset entry required for @khanacademy/wonder-blocks-cell, @khanacademy/wonder-blocks-clickable, @khanacademy/wonder-blocks-dropdown because there have been changes since the last release.
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/check.tsx#L8
'offBlack' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/check.tsx#L8
'offBlack32' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/check.tsx#L8
'white' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/check.tsx#L31
'disabled' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/check.tsx#L31
'pressed' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/check.tsx#L31
'hovered' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/check.tsx#L31
'focused' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/checkbox.tsx#L34
'activeBlue' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/checkbox.tsx#L37
'bgColor' is assigned a value but never used. Allowed unused vars must match /^_*$/u
|
Lint (ubuntu-latest, 16.x):
packages/wonder-blocks-dropdown/src/components/dropdown-core.tsx#L530
Unexpected console statement
|
MultiSelect › Controlled component › selects on item as expected:
packages/wonder-blocks-dropdown/src/components/__tests__/multi-select.test.tsx#L336
expect(element).toHaveAttribute("aria-selected", "true") // element.getAttribute("aria-selected") === "true"
Expected the element to have attribute:
aria-selected="true"
Received:
null
at Object.toHaveAttribute (packages/wonder-blocks-dropdown/src/components/__tests__/multi-select.test.tsx:336:26)
|
DropdownCore › VirtualizedList › should focus on the item after clicking on it:
packages/wonder-blocks-dropdown/src/components/__tests__/dropdown-core.test.tsx#L710
expect(element).toHaveFocus()
Expected element with focus:
<div class="" data-test-id="item-1" style="align-items: stretch; border-width: 0px; border-style: solid; box-sizing: border-box; display: flex; flex-direction: column; margin: 0px; padding: 0px; position: relative; z-index: 0; min-height: 0; min-width: 0; align-self: center; flex: 1; overflow-wrap: break-word;"><span class="" style="display: block; font-family: Lato, \"Noto Sans\", sans-serif; font-weight: 400; font-size: 16px; line-height: 20px; white-space: nowrap; user-select: none; margin-left: -8px; overflow: hidden; text-overflow: ellipsis;">Fruit # 2</span></div>
Received element with focus:
<button aria-disabled="false" class="" role="option" style="margin: 0px; padding: 0px; width: 100%; overflow: visible; background: rgb(255, 255, 255); text-decoration: none; color: rgb(33, 36, 44); box-sizing: border-box; user-select: none; outline: none; line-height: normal; cursor: pointer; display: flex; text-align: left; min-height: 40px; position: absolute; left: 0px; top: 40px; height: 40px;"><div class="" style="align-items: stretch; border-width: 0px; border-style: solid; box-sizing: border-box; display: flex; flex-direction: row; margin: 0px; padding: 12px 16px 12px 8px; position: relative; z-index: 0; min-height: 40px; min-width: 0; flex: 1; height: 40px; white-space: nowrap;"><div class="" style="align-items: center; border-width: 0px; border-style: solid; box-sizing: border-box; display: flex; flex-direction: column; margin: 0px; padding: 0px; position: relative; z-index: 0; min-height: 0; min-width: auto; align-self: center;"><div class="" style="align-items: stretch; border-width: 1px; border-style: solid; box-sizing: border-box; display: flex; flex-direction: column; margin: 0px; padding: 0px; position: relative; z-index: 0; min-height: 16px; min-width: 16px; border-radius: 3px; border-color: rgba(33,36,44,0.50);" /></div><div aria-hidden="true" class="" style="align-items: stretch; border-width: 0px; border-style: solid; box-sizing: border-box; display: flex; flex-direction: column; margin: 0px; padding: 0px; position: relative; z-index: 0; min-height: 0; min-width: 0; width: 16px; flex-basis: 16px; flex-shrink: 0;" /><div class="" data-test-id="item-1" style="align-items: stretch; border-width: 0px; border-style: solid; box-sizing: border-box; display: flex; flex-direction: column; margin: 0px; padding: 0px; position: relative; z-index: 0; min-height: 0; min-width: 0; align-self: center; flex: 1; overflow-wrap: break-word;"><span class="" style="display: block; font-family: Lato, \"Noto Sans\", sans-serif; font-weight: 400; font-size: 16px; line-height: 20px; white-space: nowrap; user-select: none; margin-left: -8px; overflow: hidden; text-overflow: ellipsis;">Fruit # 2</span></div></div></button>
Ignored nodes: comments, script, style
<html>
<head />
<body>
<div>
<div
class=""
style="align-items: stretch; border-width: 0px; border-style: solid; box-sizing: border-box; display: flex; flex-direction: column; margin: 0px; padding: 0px; position: relative; z-index: 0; min-height: 0; min-width: 0;"
>
<span
aria-atomic="true"
aria-live="polite"
aria-relevant="additions text"
class=""
data-test-id="dropdown-live-region"
style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px;"
>
200 items
</span>
<button />
</div>
</div>
<div
data-placement="bottom-start"
data-test-id="dropdown-popper"
style="position: fixed; left: 0px; top: 0px;"
>
<div
class=""
data-test-id="dropdown-core-container"
style="align-items: stretch; box-sizing: border-box; display: flex; flex-direction: column; margin: 0px; padding: 4px 0px 4px 0px; position: relative; z-index: 0; min-height: 0; min-width: 0; background-color: rgb(255, 255, 255); border-radius: 4px; border: 1px solid rgba(33,36,44,0.16);
|
ActionItem with an href › sets the 'target' prop on the underlying element:
consistency-tests/__tests__/clickables.test.tsx#L95
expect(element).toHaveAttribute("target", "_blank") // element.getAttribute("target") === "_blank"
Expected the element to have attribute:
target="_blank"
Received:
null
at Object.toHaveAttribute (consistency-tests/__tests__/clickables.test.tsx:95:22)
|
ActionItem with an href › renders an <a> if the href is '#':
consistency-tests/__tests__/clickables.test.tsx#L110
expect(received).toBe(expected) // Object.is equality
Expected: "A"
Received: "BUTTON"
at Object.toBe (consistency-tests/__tests__/clickables.test.tsx:110:30)
|
OptionItem › has expected existence of tabIndex:
consistency-tests/__tests__/clickables.test.tsx#L201
expect(element).toHaveAttribute("tabIndex", "0") // element.getAttribute("tabIndex") === "0"
Expected the element to have attribute:
tabIndex="0"
Received:
null
at Object.toHaveAttribute (consistency-tests/__tests__/clickables.test.tsx:201:31)
|
ActionItem › should render with disabled styles:
packages/wonder-blocks-dropdown/src/components/__tests__/action-item.test.tsx#L21
expect(element).toBeDisabled()
Received element is not disabled:
<button aria-disabled="true" class="" role="menuitem" style="margin: 0px; padding: 0px; width: 100%; overflow: visible; background: rgb(255, 255, 255); text-decoration: none; color: rgba(33, 36, 44, 0.32); box-sizing: border-box; user-select: none; outline: none; line-height: normal; cursor: not-allowed; display: flex; text-align: left; min-height: 40px;" />
at Object.toBeDisabled (packages/wonder-blocks-dropdown/src/components/__tests__/action-item.test.tsx:21:46)
|
ActionItem › should render an anchor if there's no router:
packages/wonder-blocks-dropdown/src/components/__tests__/action-item.test.tsx#L32
expect(received).toHaveLength(expected)
Expected length: 1
Received length: 0
Received object: []
at Object.toHaveLength (packages/wonder-blocks-dropdown/src/components/__tests__/action-item.test.tsx:32:48)
|
ActionItem › should render a Link if there's a router:
packages/wonder-blocks-dropdown/src/components/__tests__/action-item.test.tsx#L47
expect(jest.fn()).toHaveBeenCalled()
Expected number of calls: >= 1
Received number of calls: 0
at Object.toHaveBeenCalled (packages/wonder-blocks-dropdown/src/components/__tests__/action-item.test.tsx:47:25)
|
Test (ubuntu-latest, 16.x, 2/2)
Process completed with exit code 1.
|
Prime node_modules cache for primary configuration (ubuntu-latest, 16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Lint (ubuntu-latest, 16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test (ubuntu-latest, 16.x, 2/2)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test (ubuntu-latest, 16.x, 1/2)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2, codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Check build sizes (ubuntu-latest, 16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2, preactjs/compressed-size-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|