-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary: Add animations to accordion if `includeAnimation` prop is set to true. Animations are done using grid layout because it's smooth and more performant than using transitions with height or max-height. TBD: performance metrics in webapp with this implementation Issue: https://khanacademy.atlassian.net/browse/WB-1585 ## Test plan: `yarn jest packages/wonder-blocks-accordion/src/components/__tests__/accordion.test.tsx` `yarn jest packages/wonder-blocks-accordion/src/components/__tests__/accordion-section.test.tsx` `yarn jest packages/wonder-blocks-accordion/src/components/__tests__/accordion-section-header.test.tsx` Storybook http://localhost:6061/?path=/story/accordion-accordion--with-animation Author: nishasy Reviewers: kevinbarabash, jandrade, nishasy Required Reviewers: Approved By: jandrade Checks: ✅ codecov/project, ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 16.x), ✅ Test (ubuntu-latest, 16.x, 2/2), ✅ Check build sizes (ubuntu-latest, 16.x), ✅ Test (ubuntu-latest, 16.x, 1/2), ✅ Lint (ubuntu-latest, 16.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 16.x), ⏭ Chromatic - Skip on Release PR (changesets), ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 16.x), ✅ gerald, ⏭ dependabot Pull Request URL: #2096
- Loading branch information
Showing
11 changed files
with
604 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/wonder-blocks-accordion": minor | ||
--- | ||
|
||
Add animations to Accordion |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.