Revert simplifying types and add 'string' as valid option

Khan · Nov 16, 2023 · ad069a4 · ad069a4
1 parent 54c17ed
commit ad069a4
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/packages/wonder-blocks-icon/src/components/phosphor-icon.tsx b/packages/wonder-blocks-icon/src/components/phosphor-icon.tsx
@@ -35,7 +35,7 @@ type Props = Pick<AriaProps, "aria-hidden" | "aria-label"> & {
      * The icon to display. This is a reference to the icon asset
      * (imported as a static SVG file).
      */
-    icon: PhosphorIconAsset;
+    icon: PhosphorIconAsset | string;
 };
 
 /**

diff --git a/types/assets.d.ts b/types/assets.d.ts
@@ -5,4 +5,25 @@
  */
 declare module "*.jpg";
 declare module "*.png";
+
+// Support specific SVG paths from @phosphor-icons/core.
+declare type PhosphorRegular = string & {weight: "PhosphorRegular"};
+declare module "@phosphor-icons/core/regular/*.svg" {
+    const icon: PhosphorRegular;
+    export default icon;
+}
+
+declare type PhosphorBold = string & {weight: "PhosphorBold"};
+declare module "@phosphor-icons/core/bold/*-bold.svg" {
+    const icon: PhosphorBold;
+    export default icon;
+}
+
+declare type PhosphorFill = string & {weight: "PhosphorFill"};
+declare module "@phosphor-icons/core/fill/*-fill.svg" {
+    const icon: PhosphorFill;
+    export default icon;
+}
+
+// Fall back to generic SVG support.
 declare module "*.svg";