[xml] Missing group attributes on enum/bitfield arguments of core functions #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #361
Some
glGet*
functions didn't havegroup="GetPName"
.glShaderBinary
:Specification defines at least one specific value -
GL_SHADER_BINARY_FORMAT_SPIR_V
.So, i defined
ShaderBinaryFormat
group for it.Besides that - while looking for info i found quite a few people passing 0 as binary format. Is it some kind of special value "general format"? Should it also be added to
ShaderBinaryFormat
group?glFenceSync
andglWaitSync
haveflags
parameter. It's reserved for now, so only 0 can be passed into them.I added
EmptyFlags
group, so that this restriction can be easier enforced in higl-level bindings.I also applied all the same changes to extension functions, that define these functions as
<alias>
.Somewhat off topic but related questions:
glSampleMaski
takesGLbitfield
argument. And, well, it is a bitfield, but it's not whatGLbitfield
is usually used for.Maybe it would make more sense to change that argument to
GLuint
, so it's not confused with actual enum arguments?I found and added few missing
group="sync"
attributes's in extension functions, alias to core functions that have this attribute.But can someone actually explain why most arguments of type
GLsync
also have groupsync
?Is it an old thing, from when there wasn't a
GLsync
type? Does it still need to exist?