Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xml] Missing group attributes on enum/bitfield arguments of core functions #427

Merged
merged 5 commits into from
Sep 27, 2020

Conversation

SunSerega
Copy link
Contributor

Part of #361

  1. Some glGet* functions didn't have group="GetPName".

  2. glShaderBinary:
    Specification defines at least one specific value - GL_SHADER_BINARY_FORMAT_SPIR_V.
    So, i defined ShaderBinaryFormat group for it.

    Besides that - while looking for info i found quite a few people passing 0 as binary format. Is it some kind of special value "general format"? Should it also be added to ShaderBinaryFormat group?

  3. glFenceSync and glWaitSync have flags parameter. It's reserved for now, so only 0 can be passed into them.
    I added EmptyFlags group, so that this restriction can be easier enforced in higl-level bindings.

I also applied all the same changes to extension functions, that define these functions as <alias>.


Somewhat off topic but related questions:

  • glSampleMaski takes GLbitfield argument. And, well, it is a bitfield, but it's not what GLbitfield is usually used for.
    Maybe it would make more sense to change that argument to GLuint, so it's not confused with actual enum arguments?

  • I found and added few missing group="sync" attributes's in extension functions, alias to core functions that have this attribute.
    But can someone actually explain why most arguments of type GLsync also have group sync?
    Is it an old thing, from when there wasn't a GLsync type? Does it still need to exist?

Copy link
Contributor

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR! Most of the groups look good, however...

xml/gl.xml Show resolved Hide resolved
@pdaniell-nv
Copy link
Contributor

@oddhack this is approved to merge assuming you're happy with it.

@oddhack oddhack merged commit 6d6786b into KhronosGroup:master Sep 27, 2020
@SunSerega SunSerega deleted the 361-core branch June 24, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants