Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify xrEnumerateInstanceExtensionProperties for API layers #490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fredemmott
Copy link

Per https://registry.khronos.org/OpenXR/specs/1.1/html/xrspec.html#api-initialization , this function can be called before calling xrCreateInstance.

This function may: be called before an instance has been created; implementations must: not assume an instance exists.

Concretely, a bug in past versions of the Ultraleap API layer crashed if an instance had not been created.

Per https://registry.khronos.org/OpenXR/specs/1.1/html/xrspec.html#api-initialization , this function *can* be called before calling `xrCreateInstance`.

> This function may: be called before an instance has been created; implementations must: not assume an instance exists.

Concretely, a bug in past versions of the Ultraleap API layer crashed if an instance had not been created.
@fredemmott
Copy link
Author

Related docs PR: KhronosGroup/OpenXR-Docs#173

@rpavlik-bot
Copy link
Collaborator

An issue (number 2327) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2327 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

@rblenkinsopp
Copy link

I think this is a good clarification. I'd be happy for this to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants