Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PushConstant padding to 16 bytes #292

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix PushConstant padding to 16 bytes #292

merged 1 commit into from
Dec 5, 2024

Conversation

spencer-lunarg
Copy link
Contributor

This is just @danginsburg 's #291 but with tests updated

Looked at the tests and they are now correct. We were having cases like

layout(push_constant, std430) uniform PerFrameData {
    uvec2 bufferId;
} pc;

showing // size = 16, padded size = 16 when it should be // size = 8, padded size = 8 as it is now

@spencer-lunarg spencer-lunarg merged commit 7082a63 into KhronosGroup:main Dec 5, 2024
5 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-pc-padding branch December 5, 2024 04:04
@danginsburg danginsburg mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoticbob chaoticbob chaoticbob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencer-lunarg @chaoticbob