-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPV_EXT_optnone extension #260
Conversation
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would be interested in seeing this extension published as an EXT instead.
I don't mind to change it from vendor extension to EXT. Converting to draft for now |
Signed-off-by: Sidorov, Dmitry <[email protected]>
f7425f3
to
1a47100
Compare
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<meta name="generator" content="Asciidoctor 2.0.16"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was not generated with the version of asciidoctor provided in the docker image. We're working towards automatically generating and publishing specs (see #270) and one of the necessary steps involves making sure that all specs can be generated with the version provided in the docker image. It seems that we have not updated EXT extensions yet and this spec looks rather straightforward so I think re-generating the HTML needn't be a blocker to this PR going in (but would be nice to do if you can).
Merging as discussed in the September 4th teleconference. |
No description provided.