Split group_scan and group_reduce tests by data types

[jiezzhang]

To reduce overhead on template instantiation, this commit split group_reduce and group_scan tests by data type.

Besides, this commit remove 'fp16' and 'fp64' from 'get_std_type' if corresponding cmake options are set.

[keryell]

Almost there!

[bader]

Besides, this commit remove 'fp16' and 'fp64' from 'get_std_type' if corresponding cmake options are set.

I think, this deserves a separate PR. Multiple tests use get_std_type function (e.g. vector_* tests) and this change reduces the test scope for non-group tests.
If we need to remove testing half and doubles, I suggest we apply half_double_filter to group_functions tests only. But it's not clear why we would want to remove tests for these data types. Could you clarify?

[maarquitos14]

I'm trying out this branch locally and I'm seeing that the files that are now generated from cpp.in files are not really built. I'm investigating it, but I think this should not be merged until this is clear.

@jiezzhang have you verified that all the tests are built and ran? Maybe I'm misconfiguring anything?

[jiezzhang]

I'm trying out this branch locally and I'm seeing that the files that are now generated from cpp.in files are not really built. I'm investigating it, but I think this should not be merged until this is clear.

@jiezzhang have you verified that all the tests are built and ran? Maybe I'm misconfiguring anything?

Thank you! Fixed

[jiezzhang]

If we need to remove testing half and doubles, I suggest we apply half_double_filter to group_functions tests only. But it's not clear why we would want to remove tests for these data types. Could you clarify?
"-DSYCL_CTS_ENABLE_DOUBLE_TESTS" and "-DSYCL_CTS_ENABLE_HALF_TESTS" will enable/disable fp64 and fp16 tests. I think generated code should follow this behavior.
Since FP64 and FP16 is optional feature, some implementation may not compile these source files correctly (like AOT compilation flow).

[bader]

If we need to remove testing half and doubles, I suggest we apply half_double_filter to group_functions tests only. But it's not clear why we would want to remove tests for these data types. Could you clarify?
"-DSYCL_CTS_ENABLE_DOUBLE_TESTS" and "-DSYCL_CTS_ENABLE_HALF_TESTS" will enable/disable fp64 and fp16 tests. I think generated code should follow this behavior.
Since FP64 and FP16 is optional feature, some implementation may not compile these source files correctly (like AOT compilation flow).

Thanks for clarification. I would refactor the code to make it clearer. We should not add optional types unconditionally to the list of standard types in the first place. They should be added only after option value check. Adding with follow-up removing is confusing.
Let's do this refactoring in a separate PR.

[jiezzhang]

Thanks for clarification. I would refactor the code to make it clearer. We should not add optional types unconditionally to the list of standard types in the first place. They should be added only after option value check. Adding with follow-up removing is confusing.
Let's do this refactoring in a separate PR.

Sure. I have moved half_double_filter into group_functions/CMakeLists.txt for this commit

[maarquitos14]

I have experimented locally with this PR and works perfectly. The improvement in compile time and runtime is very significant.

[steffenlarsen]

Great! 🚀

[bader]

@keryell, all comments have been resolved. Could you take a look, please?

[keryell]

Thanks!