Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Drop legacy get/setElement helpers #828

Merged
merged 4 commits into from
Nov 6, 2023
Merged

[NFC] Drop legacy get/setElement helpers #828

merged 4 commits into from
Nov 6, 2023

Conversation

AlexeySachkov
Copy link
Contributor

SYCL 2020 introduced operator[] to vec class and we can use it directly instead of going through the helper.

@AlexeySachkov
[NFC] Drop legacy get/setElement helpers
645536e 
SYCL 2020 introduced `operator[]` to `vec` class and we can use it
directly instead of going through the helper.
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner November 3, 2023 15:03
@bader bader added the help wanted Extra attention is needed label Nov 3, 2023
keryell
keryell approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't SYCL great? :-)

@bader bader merged commit 9092945 into KhronosGroup:SYCL-2020 Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeySachkov @keryell @bader