Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change abs_diff return type #836

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Change abs_diff return type #836

merged 4 commits into from
Nov 28, 2023

Conversation

steffenlarsen
Copy link
Contributor

@steffenlarsen steffenlarsen commented Nov 22, 2023

Following KhronosGroup/SYCL-Docs#458 the return
type of abs_diff was changed to be the same as the input types. This
commit makes the corresponding changes to the CTS tests for it.

Signed-off-by: Larsen, Steffen [email protected]

@steffenlarsen steffenlarsen requested a review from a team as a code owner November 22, 2023 07:22
@steffenlarsen steffenlarsen changed the title Uplift DPC++ to 2a3e1ab824f072670c186ec715f29b88c9df9d45 Uplift DPC++ to 6bce7f64f51a4370052bffa3fa257ca16d8aad9e Nov 22, 2023
Following KhronosGroup/SYCL-Docs#458 the return
type of abs_diff was changed to be the same as the input types. This
commit makes the corresponding changes to the CTS tests for it.

Signed-off-by: Larsen, Steffen <[email protected]>
@bader bader added the help wanted Extra attention is needed label Nov 23, 2023
@bader bader changed the title Uplift DPC++ to 6bce7f64f51a4370052bffa3fa257ca16d8aad9e Change abs_diff return type Nov 23, 2023
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bader bader merged commit b0ab9bc into SYCL-2020 Nov 28, 2023
8 checks passed
@bader bader deleted the steffen/bump_dpcpp_version branch November 28, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants