Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Alias for c++20 modules target #2048

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

M2-TE
Copy link
Contributor

@M2-TE M2-TE commented Jan 20, 2025

Created an alias target similar to Vulkan::Hpp, while also renaming the Vulkan-Hpp target to VulkanHpp to be similar in name to VulkanHppModule.

Moving VulkanHpp target above module target allows linking to it for its include directory.

@M2-TE M2-TE changed the title Created alias for c++20 modules target CMake: Alias for c++20 modules target Jan 20, 2025
@asuessenbach
Copy link
Contributor

asuessenbach commented Jan 21, 2025

It seems, the windows runners have some problems right now.
With #2050 I've changed the windows workflow to do one job per C++-standard, instead of looping over them in one job. That seems to be more stable.
So, if you could rebase your PR and try again?

@M2-TE
Copy link
Contributor Author

M2-TE commented Jan 21, 2025

Looks like that did the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants