Make Xrandr not implicitly required when x11 is used #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 315151. |
|
CI Vulkan-Loader build # 2818 running. |
The previous logic made xrandr a required header whenever x11 was available which doesn't honestly convey build requirements to users. This commit add BUILD_WSI_XLIB_XRANDR_SUPPORT as a build option that defaults to ON (for platforms which support x11) so the xrandr requirement can be configured by users directly.
charles-lunarg
force-pushed
the
fix_xrandr_requirement
branch
from
570b04e to
6a1712f
Compare
|
CI Vulkan-Loader build queued with queue ID 315169. |
|
CI Vulkan-Loader build # 2819 running. |
|
CI Vulkan-Loader build # 2819 failed. |
PKG_CONFIG_EXECTUABLE is a CMake variable that sets the pkg-config executable used, allowing the use of the 32 bit pkg-config when looking for pkg-config packages. The prior version of the 32 bit job actually used the 64 bit packages but that happened to work okay because the only things used from the 64 bit packages were header files, which are arch agnostic.
|
CI Vulkan-Loader build queued with queue ID 329578. |
|
CI Vulkan-Loader build # 2836 running. |
|
CI Vulkan-Loader build # 2836 failed. |
|
CI Vulkan-Loader build queued with queue ID 329667. |
|
CI Vulkan-Loader build # 2837 running. |
|
CI Vulkan-Loader build # 2837 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic made xrandr a required header whenever x11 was available which doesn't honestly convey build requirements to users.
This commit add BUILD_WSI_XLIB_XRANDR_SUPPORT as a build option that defaults to ON (for platforms which support x11) so the xrandr requirement can be configured by users directly.