This repository has been archived by the owner on Jul 19, 2018. It is now read-only.
WIP -- specialization constant support #1646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisforbes
requested review from
mark-lunarg,
tobine,
karl-lunarg and
mikew-lunarg
tobine
reviewed
Apr 12, 2017
|
@tobine perhaps. It's easy to add one. |
|
Note there's still some issues here:
|
|
@tobine What do you think about landing 1-5 now, and the rest later? |
|
@chrisforbes Yes, landing 1-5 asap makes sense. Spin off into separate PR and run through our farm to be safe. Assuming clean it has my +1. |
Currently we don't even look at these, and instead assume `1`, which is completely bogus.
These shaders are fine without the specialization -- but with it applied, we should get a type mismatch on the array sizes.
The SC code was previously reaching directly into the layer_data, which we'd rather not do. Also removes some iterator clutter from SC.
This was done long ago.
We're about to actually apply specializations, so let's do this work /before/ broken specializations will cause us to crash.
|
cmake for this is no good. I need to look at it a bit more. |
|
Can anything be done with the work here, or should we just archive this for now? |
|
@chrisforbes, this repository will close for write access on Sunday, 5/13/2018. If it is pushed before that time it will be present in the follow-on Vulkan-ValidationLayers repository on Monday, otherwise a new PR will be required in the new repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches 1-5 do some housekeeping in the test framework in order to make writing this test easier.
Patches 6-7 are adding new test cases (which currently fail).
Still to come: actual implementation to make the tests pass.