Skip to content

Commit

Permalink
syncval Revert "Apply render pass final transitions always"
Browse files Browse the repository at this point in the history
The change as written causes CTS crashes, as it doesn't make changes to
the consumers of the altered data structures.

This reverts commit 41709ca.
  • Loading branch information
jzulauf-lunarg authored and juan-lunarg committed Jan 27, 2023
1 parent efc0e56 commit d5d4232
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions layers/render_pass_state.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ struct AttachmentTracker { // This is really only of local interest, but a bit

for (uint32_t attachment = 0; attachment < attachment_count; ++attachment) {
const auto final_layout = rp->createInfo.pAttachments[attachment].finalLayout;
// Add final transitions for attachments at the end of the render pass.
if (final_layout != attachment_layout[attachment]) {
// Add final transitions for attachments that were used and change layout.
if ((last[attachment] != VK_SUBPASS_EXTERNAL) && final_layout != attachment_layout[attachment]) {
final_transitions.emplace_back(last[attachment], attachment, attachment_layout[attachment], final_layout);
}
}
Expand Down

0 comments on commit d5d4232

Please sign in to comment.