Require rgb renderable webgl1 #3364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks all texture formats for filterable and color-renderable. WebGL 1 and 2. WebGL 1's RGB8 doesn't look like it's spec-required. Should it be? Every device and browser I tested supports it, and it's color-renderable in ES3/webgl2.
kenrussell
reviewed
Dec 2, 2021
| <li> <code>RGB</code>, <code>UNSIGNED_BYTE</code> | ||
| <li> <code>RGBA</code>, <code>UNSIGNED_SHORT_4_4_4_4</code> | ||
| <li> <code>RGBA</code>, <code>UNSIGNED_SHORT_4_4_4_4</code> | ||
| <li> <code>RGB</code>, <code>UNSIGNED_SHORT_5_6_5</code> |
There was a problem hiding this comment.
A couple of recollections:
- Early ES 2.0 implementations didn't guarantee renderability of these formats.
- I recall that ES 3.0 revoked renderability of some RGB formats, but looking again at the spec, RGB8 is in fact guaranteed to be color-renderable (ES 3.0.6 p.130).
What are the concerns we should be thinking of when asserting these formats are renderable in both WebGL 1.0 and 2.0?
|
So I wrote a C++ test and 5_5_5_1 fails on NVidia MacOS |
|
Not surprising. Note though that ANGLE would likely emulate that format on top of RGBA8 as a driver bug workaround, since it's legal for the implementation to provide more bits of precision. |
kenrussell
added a commit
that referenced
this pull request
Dec 23, 2021
Testing this pull request: #3364 off the main branch of the KhronosGroup/WebGL repository. Require all RGB and RGBA textures to be renderable in webgl1. Authored-by: Kelsey Gilbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3357