Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance2/uniforms/uniform-block-idents-as-expr. #3693

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kdashg
Copy link
Contributor

@kdashg kdashg commented Sep 20, 2024

Fixes #3644.

Fails 4-6 subtests on top-of-tree Chrome and Firefox.

@kdashg
Copy link
Contributor Author

kdashg commented Sep 20, 2024

(I only tested on Windows)

@kenrussell
Copy link
Member

Thanks very much Kelsey for putting this together. On current Chromium, the failing cases are:

test[13]: {"programOk":false,"vsrc":"uniform BlockName { vec4 member; } InstanceName;\nvoid f() { InstanceName; }","fsrc":""}
FAIL Expected linked: false, was true

test[14]: {"programOk":false,"vsrc":"","fsrc":"uniform BlockName { vec4 member; } InstanceName;\nvoid f() { InstanceName; }"}
FAIL Expected linked: false, was true

test[23]: {"programOk":false,"vsrc":"uniform BlockName { vec4 member; } InstanceName[1];\nvoid f() { InstanceName; }","fsrc":""}
FAIL Expected linked: false, was true

test[24]: {"programOk":false,"vsrc":"","fsrc":"uniform BlockName { vec4 member; } InstanceName[1];\nvoid f() { InstanceName; }"}
FAIL Expected linked: false, was true

test[27]: {"programOk":false,"vsrc":"uniform BlockName { vec4 member; } InstanceName[1];\nvoid f() { InstanceName[0]; }","fsrc":""}
FAIL Expected linked: false, was true

test[28]: {"programOk":false,"vsrc":"","fsrc":"uniform BlockName { vec4 member; } InstanceName[1];\nvoid f() { InstanceName[0]; }"}
FAIL Expected linked: false, was true

What would be needed to pass these? Does ANGLE's shader translator need to fail compilation of these vertex / fragment shaders? Is more complex validation needed at link time?

Copy link
Contributor

@kkinnunen-apple kkinnunen-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kenrussell
Copy link
Member

Thanks Kelsey for the test.

@kenrussell kenrussell merged commit 7b00c8c into KhronosGroup:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify discarded expressions of uniform block reference through instance name only
4 participants