Skip to content

Commit

Permalink
cmake: fix linking of stubbed libraries
Browse files Browse the repository at this point in the history
  • Loading branch information
abouvier committed Dec 13, 2024
1 parent 340bf88 commit 54c8d2d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions SPIRV/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,11 @@ if(WIN32 AND BUILD_SHARED_LIBS)
endif()

if(ENABLE_OPT)
target_link_libraries(SPIRV PRIVATE glslang PUBLIC SPIRV-Tools-opt)
target_link_libraries(SPIRV INTERFACE glslang PUBLIC SPIRV-Tools-opt)
target_include_directories(SPIRV PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../External>)
else()
target_link_libraries(SPIRV PRIVATE glslang)
target_link_libraries(SPIRV INTERFACE glslang)
endif()

if(WIN32)
Expand Down
2 changes: 1 addition & 1 deletion glslang/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ endif()
add_library(MachineIndependent STATIC stub.cpp)
set_property(TARGET MachineIndependent PROPERTY POSITION_INDEPENDENT_CODE ON)
set_property(TARGET MachineIndependent PROPERTY FOLDER glslang)
target_link_libraries(MachineIndependent PRIVATE glslang)
target_link_libraries(MachineIndependent INTERFACE glslang)

if (NOT MSVC)
# -Wunused-but-set-variable is triggered in code generated by bison that we do not control. Turn this warning off, but only for the generated.
Expand Down

0 comments on commit 54c8d2d

Please sign in to comment.