Fix interpolant ES error #3335
Merged
Fix interpolant ES error #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncesario-lunarg
commented
Sep 15, 2023
Comment on lines
2546
to
2548
| TIntermediate::traverseLValueBase( | ||
| arg0, swizzleOkay, false, | ||
| [&isValid, &isIn, &interpolantErrorMsg, esProfile, &structAccessOp](const TIntermNode& n) { |
There was a problem hiding this comment.
@arcady-lunarg @jeremy-lunarg I went back and forth with creating a dedicated function to fix this or a more generic function to traverse. Let me know what you prefer style-wise.
There was a problem hiding this comment.
I think it's better to keep it inline but I also would prefer a brief comment explaining what this is doing.
ncesario-lunarg
commented
Sep 15, 2023
arcady-lunarg
requested changes
Sep 15, 2023
Comment on lines
2546
to
2548
| TIntermediate::traverseLValueBase( | ||
| arg0, swizzleOkay, false, | ||
| [&isValid, &isIn, &interpolantErrorMsg, esProfile, &structAccessOp](const TIntermNode& n) { |
There was a problem hiding this comment.
I think it's better to keep it inline but I also would prefer a brief comment explaining what this is doing.
ncesario-lunarg
force-pushed
the
issue-3277
branch
from
a255097 to
ea16f57
Compare
arcady-lunarg
requested changes
Nov 9, 2023
| @@ -573,6 +574,8 @@ class TIntermediate { | |||
|
|
|||
| // Tree ops | |||
| static const TIntermTyped* findLValueBase(const TIntermTyped*, bool swizzleOkay , bool BufferReferenceOk = false); | |||
There was a problem hiding this comment.
I think you need to delete this because the function doesn't exist.
There was a problem hiding this comment.
Ah, yep, thanks for catching that!
The restriction of no swizzling and no struct fields as an interpolant were not being checked when using the ES profile. Fixes KhronosGroup#3277.
ncesario-lunarg
force-pushed
the
issue-3277
branch
from
ea16f57 to
2fda422
Compare
arcady-lunarg
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restriction of no swizzling and no struct fields as an interpolant were not being checked when using the ES profile.
Fixes #3277.