Add missing initialization of compile_only field for SPIRV C interface
#3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeremy-lunarg
approved these changes
Oct 16, 2023
arcady-lunarg
added a commit
to arcady-lunarg/glslang
that referenced
this pull request
Oct 18, 2023
This will prevent any recurrence of issues like the one addressed by PR KhronosGroup#3364.
arcady-lunarg
added a commit
that referenced
this pull request
Oct 19, 2023
This will prevent any recurrence of issues like the one addressed by PR #3364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the
compile_onlystruct field ofglslang_spv_options_tis not being set, so it's just holding garbage memory and causing unwanted behaviour by implicitly resolving totruemost times.