-
Notifications
You must be signed in to change notification settings - Fork 742
Create IGBT_Module library #2913
base: master
Are you sure you want to change the base?
Conversation
Update fork
Also added R8 and R6 aliases. It is only memory option.
sync master branch
Sync master
Sync master
Sync master
fix travis
Hi @aris-kimi , thanks for contributing, A few comments I have during my review:
Do you have attributed the pin number yourself ? Maybe in this case something like BGA packages, with letter for the column and number for the line will be better, let see what the footprint experts say. Cheers, |
I have it like this in order to be similar with the above. Power stages kept exchangable with each other. If you still need this to change inform me to start working. |
Just saw the edit @myfreescalewebpage , yes after travis violation that was the best i could thought off, but i liked your idea more. I will change this if footprint reviewer agrees. Short question, do you might know if with new s-exp format those special characters will be allowed? |
Actually, they're not explicitly forbidden in descriptions (see https://kicad-pcb.org/libraries/klc/G1.1/), but we try to limit them because the devs aren't overly confident in the current UTF-8 implementation. Edit: To answer the question, no, the new format isn't going to change anything directly. |
@aris-kimi yes when you are a developer you are not always confident with special characters and I understand this :D If we accept this we will have plenty of Cyrillic, Spanish, Swedish, etc symbols and it's not really wanted. |
Just need to wait the footprint now. |
@myfreescalewebpage , i have to share a thought since i just saw |
To be honest with you I have think to the name of the library too, but "IGBT_Module" is not bad. |
Same with the footprint PR, second try for addition of IGBT_Module library, with some other symbols only from infineon (previous PR has only some from ST).
I would like to ask any reviewer to give priority to this one over the other.
Edit:
I have power stage connections exchangeable between symbols from previous/future (similar symbol) PRs.
I just saw letters instead of numbers for footprint pins. I wasn't aware of that. I custom-numbered them to avoid travis violation after
KLC S4.1.3 Pin numbers must be unique (no two pins may have the same number)
I will act after guidance.
Addition:
FP50R06W2E3: https://www.infineon.com/dgdl/Infineon-FP50R06W2E3-DS-v02_02-EN.pdf?fileId=db3a30431b3e89eb011b455c99987d24
Aliases:
FP15R12W2T4: https://www.infineon.com/dgdl/Infineon-FP15R12W2T4-DS-v03_00-en_de.pdf?fileId=db3a30433ba77ced013bae67c3eb3a5e
FP25R12W2T4: https://www.infineon.com/dgdl/Infineon-FP25R12W2T4-DS-v02_02-EN.pdf?fileId=db3a3043163797a60116389cdaeb0183
FP25R12W2T4P: https://www.infineon.com/dgdl/Infineon-FP25R12W2T4P-DS-v03_00-EN.pdf?fileId=5546d4625bd71aa0015bfbc806e571fc
FP35R12W2T4: https://www.infineon.com/dgdl/Infineon-FP35R12W2T4-DS-v02_02-EN.pdf?fileId=db3a3043163797a6011638a0541501a0
FP35R12W2T4P: https://www.infineon.com/dgdl/Infineon-FP35R12W2T4P-DS-v03_00-EN.pdf?fileId=5546d4625bd71aa0015bfbbf0d7a71f8
Footprint PR: KiCad/kicad-footprints#2388
Red numbers is custom numbering for pin assignment:
Travis footprint violation:
Violating S5.1
Thank you for your time.
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.