Skip to content

Commit

Permalink
elysiajs#33 set access-control-expose header instead of exposed header
Browse files Browse the repository at this point in the history
  • Loading branch information
KilianB committed Dec 4, 2023
1 parent 11237e5 commit 0f4942f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ interface CORSConfig {
/**
* @default `*`
*
* Assign **Access-Control-Exposed-Headers** header.
* Assign **Access-Control-Expose-Headers** header.
*
* Return the specified headers to request in CORS mode.
*
Expand Down Expand Up @@ -289,7 +289,7 @@ export const cors = (
: allowedHeaders.join(', ')

if (exposedHeaders.length)
set.headers['Access-Control-Exposed-Headers'] =
set.headers['Access-Control-Expose-Headers'] =
typeof exposedHeaders === 'string'
? exposedHeaders
: exposedHeaders.join(', ')
Expand Down
4 changes: 2 additions & 2 deletions test/exposed-header.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('Exposed Headers', () => {
.get('/', () => 'HI')

const res = await app.handle(req('/'))
expect(res.headers.get('Access-Control-Exposed-Headers')).toBe(
expect(res.headers.get('Access-Control-Expose-Headers')).toBe(
'Content-Type'
)
})
Expand All @@ -30,7 +30,7 @@ describe('Exposed Headers', () => {
.get('/', () => 'HI')

const res = await app.handle(req('/'))
expect(res.headers.get('Access-Control-Exposed-Headers')).toBe(
expect(res.headers.get('Access-Control-Expose-Headers')).toBe(
'Content-Type, X-Imaginary-Value'
)
})
Expand Down
2 changes: 1 addition & 1 deletion test/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe('CORS', () => {
expect(res.headers.get('Access-Control-Allow-Origin')).toBe('*')
expect(res.headers.get('Access-Control-Allow-Methods')).toBe('*')
expect(res.headers.get('Access-Control-Allow-Headers')).toBe('*')
expect(res.headers.get('Access-Control-Exposed-Headers')).toBe('*')
expect(res.headers.get('Access-Control-Expose-Headers')).toBe('*')
expect(res.headers.get('Access-Control-Allow-Credentials')).toBe(null)
})
})

0 comments on commit 0f4942f

Please sign in to comment.