fix: obtain ldrlock before dumping leaks, to avoid deadlocks #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olving callstack (e.g. GetModuleName) While dumping leaks, vld calls GetModuleName during callstack resolving, but this function takes ldrlock. If other threads call functions taking ldrlock and also triggering vld code (e.g. module unloading) this leads to a deadlock. Signed-off-by: rglarix <[email protected]>
|
@rglarix Thank you for all PR's. I will try to find time to review in the coming weeks. We also need to try fix build on AppVeyor |
|
Great, thank you. |
olivierlevon
pushed a commit
to olivierlevon/vld
that referenced
this pull request
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While dumping leaks, vld calls GetModuleName during callstack resolving, but this function needs ldrlock.
If other threads call functions taking ldrlock and also triggering vld code (e.g. module unloading) this leads to a deadlock.
The thread dumping leaks has g_heapMapLock and wants ldrlock, while the other has ldrlock (usually obtained directly by the windows method) and wants g_heapMapLock.
This patch fixes this situation by just taking ldrlock before doing a leak dump