Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/result iter #251

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Refactor/result iter #251

merged 3 commits into from
Dec 6, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Dec 6, 2024 •
edited
Loading

What problem does this PR solve?

  • use ResultIter(DatabaseIter&TransactionIter) for DataBase result return (delayed data acquisition reduces computational overhead)
  • enumerate the childrens attribute of LogicalPlan (more low memory)

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Dec 6, 2024
@KKould KKould merged commit 5ac7795 into main Dec 6, 2024
5 of 6 checks passed
@KKould KKould deleted the refactor/result_iter branch December 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KKould KKould

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KKould