feat: Refactor 'DataValue' length check logic; add support for varchar computations #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKould
requested changes
Sep 16, 2023
src/binder/insert.rs
Outdated
| @@ -52,6 +52,11 @@ impl<S: Storage> Binder<S> { | |||
| let cast_value = DataValue::clone(value) | |||
| .cast(columns[i].datatype())?; | |||
|
|
|||
| // Check if the value length is too long | |||
| if Some(cast_value.to_raw().len()) > columns[i].datatype().raw_len() { | |||
There was a problem hiding this comment.
DataValue adds a Check method to check the upper limit of data type
loloxwg
changed the title
…r computations This commit revises the mechanism for checking limit conditions on variable length types such as varchar, moving the check from 'src/binder/insert.rs' to 'src/types/value.rs' to centralize the control. It also implements expression computation for the Udf8 data type. Furthermore, the now-unnecessary `Nvarchar` type has been removed. This overhaul enhances robustness against incorrect inputs in variable length fields and improves the computational abilities for the Utf8 data type.
loloxwg
force-pushed
the
main
branch
4 times, most recently
from
0d8118b to
15e72bc
Compare
KKould
reviewed
Sep 17, 2023
KKould
requested changes
Sep 17, 2023
KKould
reviewed
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This commit revises the mechanism for checking limit conditions on variable length types such as varchar, moving the check from 'src/binder/insert.rs' to 'src/types/value.rs' to centralize the control. It also implements expression computation for the Udf8 data type. Furthermore, the now-unnecessary
Nvarchartype has been removed. This overhaul enhances robustness against incorrect inputs in variable length fields and improves the computational abilities for the Utf8 data type.Issue link:
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer