feat: Add 'show tables' functionality in SQL executor #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces 'show tables' feature, allowing users to display table names in the database. Necessary changes were made in the execution module, database, binder, and storage to facilitate this feature. This includes addition of `ShowTables` struct and implementing the `Executor` trait for it, modifications in `Binder` to create a logical plan for 'show tables' commands, and adding `show_tables` function in storage to return a list of existing table names. Additionally, a 'ShowTablesOperator' was added in operator module to support operation, and new test cases were added to validate the modifications.
KKould
reviewed
Sep 17, 2023
src/storage/table_codec.rs
Outdated
| table_name, | ||
| ); | ||
|
|
||
| bincode::serialize(&table_name).ok() |
There was a problem hiding this comment.
oops, On the Index branch I am currently developing, I added this to the TypeError for bincode errors.
#[error("bindcode")]
Bincode(
#[source]
#[from]
Box<bincode::ErrorKind>
)So I can throw the error directly instead of returning Option:
There was a problem hiding this comment.
When will you fix it to prevent conflict?
KKould
reviewed
Sep 17, 2023
KKould
reviewed
Sep 20, 2023
Functions `show_tables` in the Storage trait and its implementations in Kip and Memory now return a tuple containing table name and column count. The functions `encode_root_table` and `decode_root_table` in table_codec have been updated for the new format. These changes improve utility of `show_tables` by providing more detailed information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces 'show tables' feature, allowing users to display table names in the database. Necessary changes were made in the execution module, database, binder, and storage to facilitate this feature. This includes addition of
ShowTablesstruct and implementing theExecutortrait for it, modifications inBinderto create a logical plan for 'show tables' commands, and addingshow_tablesfunction in storage to return a list of existing table names. Additionally, a 'ShowTablesOperator' was added in operator module to support operation, and new test cases were added to validate the modifications.What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer