Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing files to SDist #171

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 24, 2024

Quick fix for missing files in SDist, which also are missing from the wheel if you build the wheel from the SDist. But not if you build directly, which is why tests were passing. See #168.

$ uvx check-dist
SDist does not match git

SDist only:


Git only:
  docs/CNAME
  docs/api.md
  docs/changelog.md
  docs/index.md
  fuzz/README.md
  fuzz/corpus/fuzz_decoders/fuzz_decoders
  fuzz/corpus/fuzz_form/fuzz_form
  fuzz/corpus/fuzz_options_header/fuzz_options_header
  fuzz/fuzz_decoders.py
  fuzz/fuzz_form.py
  fuzz/fuzz_options_header.py
  fuzz/helpers.py
  mkdocs.yml
  scripts/README.md
  scripts/check
  scripts/lint
  scripts/rename
  scripts/setup
  scripts/test
  uv.lock

That looks pretty safe now.

@defnull
Copy link
Contributor

defnull commented Oct 24, 2024

Can you remove the "_python_multipart.pth", "_python_multipart_loader.py" part?

@henryiii henryiii mentioned this pull request Oct 24, 2024
@henryiii
Copy link
Contributor Author

henryiii commented Oct 24, 2024

Yes, sure. Completely forgot about this, most of the time I use hatching's .gitignore based filtering instead of a manual list. The manual list is fine - as long as it's checked (see #172)!

Signed-off-by: Henry Schreiner <[email protected]>
@musicinmybrain
Copy link

This seems to work.

I wanted to verify that this doesn’t rely on building wheels with hatch build in particular, so I also tested this in a git checkout with python3 -m build and confirmed that the compatibility multipart/ package is still included in the wheel.

@Kludex Kludex merged commit c06830d into Kludex:master Oct 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants