Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file size for packages #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cacciatc
Copy link
Contributor

PR to address: KnightOS/KnightOS#305

A couple notes:

  • Added a new column to the package table for tracking the number of bytes. Therefore the db needs to be migrated.
  • New and version bumped package uploads have their file size calculated on upload.
  • All existing packages can have their file sizes calculated and saved in the db by running

    python manage.py calc_package_file_sizes
  • Accordingly, I added a new dependency flask-script in order to do so (therefore updating w/ pip may be in order).
  • The file size is saved in bytes and displayed as KB. KB seemed to be the best fit based on the packages I looked at.

@cacciatc
Copy link
Contributor Author

Howdy,

Was going through my older PRs and saw this one. Any questions you need answered or suggested changes?

@ddevault
Copy link
Member

Sorry, this one is just complicated to deploy so I've been holding off on reviewing it until I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants