Deconz ZGP Fixes #795
Closed
Deconz ZGP Fixes #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The options field is a bitfield, and shouldn't have byte order reversed.
@ChrisHae is this something you could help with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following in the footsteps of #536 I'm trying to spruce up ZGP handling a bit between Deconz and Z2M. Namely: I'm trying to reduce the amount of bespoke processing happening in the deconz driver and move more of it to the controller. This is the first push, which specifically fixes "options" handling.
I could really use some guidance on the frame parsing side, though. dresden-elektronik/deconz-serial-protocol#13 (comment) indicates that this should be just a raw ZGP frame pushed down the serial pipe, but for GP commissioning notifications data is in places I simply don't expect it to be. Why is options at offset 14, and frameCounter 36 for example? I'm sure there's something I'm missing here.