V2 erc activation #2235
Closed
V2 erc activation #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR should be prioritized |
smk762
commented
Dec 14, 2023
|
|
||
| if (s >= 5s) | ||
| if (s_coins_status >= 15s) |
There was a problem hiding this comment.
leaving this out of next integration attempt as a potential source of crashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_erc20andenable_eth_with_tokensUnfortunately using the new methods is causing a
Trace/breakpoint trap (core dumped)so though they are present in the code, they are not in use at the moment. More testing needs to be done to isolate and resolve the cause.