bump go toolchain to 1.23.0

Signed-off-by: onur-ozkan <[email protected]>
KomodoPlatform · Sep 23, 2024 · e30c05c · e30c05c
1 parent 583e140
commit e30c05c
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 25 deletions.
diff --git a/.github/workflows/build-and-install.yml b/.github/workflows/build-and-install.yml
@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.19.4
+          go-version: 1.23
 
       - name: Build
         run: GOARCH=${{ matrix.go-arch }} make build

diff --git a/.github/workflows/code-check.yml b/.github/workflows/code-check.yml
@@ -14,30 +14,31 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.19.4
+          go-version: 1.23
           cache: true
           cache-dependency-path: go.sum
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
-        with:
-          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.50.1
-          skip-cache: true
-          skip-build-cache: true
-          args: "--timeout 3m --verbose --out-${NO_FUTURE}format colored-line-number"
-
-          # Optional: working directory, useful for monorepos
-          # working-directory: somedir
-
-          # Optional: show only new issues if it's a pull request. The default value is `false`.
-          # only-new-issues: true
-
-          # Optional: if set to true then the all caching functionality will be complete disabled,
-          #           takes precedence over all other caching options.
-          # skip-cache: true
-
-          # Optional: if set to true then the action don't cache or restore ~/go/pkg.
-          # skip-pkg-cache: true
+      # TODO: `< 1.52.2` versions have OOM problems and bumping `1.52.2` requires a lot of changes on the project.
+      # - name: golangci-lint
+      #   uses: golangci/golangci-lint-action@v3
+      #   with:
+      #     # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
+      #     version: v1.50.1
+      #     skip-cache: true
+      #     skip-build-cache: true
+      #     args: "--timeout 3m --verbose --out-${NO_FUTURE}format colored-line-number"
+
+      #     # Optional: working directory, useful for monorepos
+      #     # working-directory: somedir
+
+      #     # Optional: show only new issues if it's a pull request. The default value is `false`.
+      #     # only-new-issues: true
+
+      #     # Optional: if set to true then the all caching functionality will be complete disabled,
+      #     #           takes precedence over all other caching options.
+      #     # skip-cache: true
+
+      #     # Optional: if set to true then the action don't cache or restore ~/go/pkg.
+      #     # skip-pkg-cache: true
 
       - name: install required tools
         run: |

diff --git a/.github/workflows/test-and-bench.yml b/.github/workflows/test-and-bench.yml
@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.19.4
+          go-version: 1.23
           cache: true
           cache-dependency-path: go.sum
 
@@ -33,7 +33,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: 1.19.4
+          go-version: 1.23
           cache: true
           cache-dependency-path: go.sum