Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(mesh): update docs and changelog #6476

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

kong[bot]
Copy link
Contributor

@kong kong bot commented Nov 6, 2023

Syncing docs from source code.

Generated by action

@kong kong bot requested a review from a team as a code owner November 6, 2023 23:17
@kong kong bot added the review:autodoc Automatically applied to PRs generated through GH actions. label Nov 6, 2023
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 2c8187c
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/65532e5d32e49800085d686c
😎 Deploy Preview https://deploy-preview-6476--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 91 (🟢 up 1 from production)
Accessibility: 80 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kong kong bot force-pushed the chore/docs-sync-Kong/kong-mesh branch from 170e58c to df9456d Compare November 7, 2023 16:01
@kong kong bot force-pushed the chore/docs-sync-Kong/kong-mesh branch 2 times, most recently from f1ece12 to 8410d63 Compare November 9, 2023 08:18
@cloudjumpercat
Copy link
Contributor

@michaelbeaumont Should we hold off on merging this until 2.5 is released? It looks like it adds the 2.5 version to the docs site, but clicking on it results in a 404.

@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Nov 9, 2023

@cloudjumpercat I guess yea, the PR wasn't merged after I approved to add 2.4.4 and then got updated after we created the 2.5 branch

@kong kong bot force-pushed the chore/docs-sync-Kong/kong-mesh branch from 8410d63 to db069d2 Compare November 10, 2023 08:05
@cloudjumpercat cloudjumpercat added do not merge Issues/ PRs whose changes should not be merged at this time review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? labels Nov 10, 2023
@cloudjumpercat cloudjumpercat added this to the Mesh 2.5 milestone Nov 10, 2023
@kong kong bot force-pushed the chore/docs-sync-Kong/kong-mesh branch from db069d2 to 648e564 Compare November 11, 2023 08:05
@cloudjumpercat cloudjumpercat added pending:release Waiting for the PM to merge skip-changelog and removed do not merge Issues/ PRs whose changes should not be merged at this time labels Nov 11, 2023
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelbeaumont I'll approve this PR since most of the docs team will be out on the 13th and I wanted to make sure this was approved so you can merge it in if the release goes out that day. The 2.5 docs result in a 404 in this PR, but that is fixed in #6495 . I think there will be merge conflicts between those two PRs, so I can drop in the morning of the 13th (CST) quickly to see if these can be merged or a docs member can help merge them when we're all back on Wednesday.

@kong kong bot force-pushed the chore/docs-sync-Kong/kong-mesh branch from 648e564 to 033832f Compare November 12, 2023 08:05
Signed-off-by: kumahq[bot] <110050114+kumahq[bot]@users.noreply.github.com>
@kong kong bot force-pushed the chore/docs-sync-Kong/kong-mesh branch from 033832f to e010a14 Compare November 13, 2023 08:06
app/_data/docs_nav_mesh_2.5.x.yml Outdated Show resolved Hide resolved
@slonka slonka merged commit ae300d6 into main Nov 14, 2023
15 checks passed
@slonka slonka deleted the chore/docs-sync-Kong/kong-mesh branch November 14, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:check-skipped:generated-files pending:release Waiting for the PM to merge review:autodoc Automatically applied to PRs generated through GH actions. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants