Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multi-geo GA #6499

Merged
merged 9 commits into from
Nov 21, 2023
Merged

feat: Multi-geo GA #6499

merged 9 commits into from
Nov 21, 2023

Conversation

cloudjumpercat
Copy link
Contributor

Description

Multi-geo is going GA, so we needed to pull in the current beta docs from the konnect branch, as well as add information about the newly added geo, AU.

DOCU-2593

Testing instructions

Preview link: many docs were changed

Checklist

  • Review label added
  • PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

@cloudjumpercat cloudjumpercat added do not merge Issues/ PRs whose changes should not be merged at this time review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? labels Nov 9, 2023
@cloudjumpercat cloudjumpercat requested a review from a team as a code owner November 9, 2023 17:17
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 60fbe93
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/655b77181796900008b45be0
😎 Deploy Preview https://deploy-preview-6499--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 91 (🟢 up 2 from production)
Accessibility: 80 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@acgoldsmith acgoldsmith added this to the 2023-11 Konnect milestone Nov 14, 2023
Adding region-specific URLs, confirmed region codes from https://deploy-preview-6499--kongdocs.netlify.app/konnect/geo/
Copy link
Contributor

@smritikjaggi smritikjaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Diana! Left some comments

app/konnect/geo.md Outdated Show resolved Hide resolved
app/konnect/geo.md Outdated Show resolved Hide resolved
app/_src/deck/guides/konnect.md Outdated Show resolved Hide resolved
app/konnect/account-management/index.md Outdated Show resolved Hide resolved
app/konnect/api-products/service-documentation.md Outdated Show resolved Hide resolved
app/konnect/updates.md Show resolved Hide resolved
* EU
* AU

: For more information, see [Geographic regions](/koonect/geo/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo with "koonect"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was me, thank you 😆

app/konnect/api/index.md Outdated Show resolved Hide resolved
app/konnect/api/index.md Outdated Show resolved Hide resolved
app/konnect/dev-portal/applications/enable-app-reg.md Outdated Show resolved Hide resolved
@acgoldsmith acgoldsmith self-assigned this Nov 17, 2023
Copy link
Contributor

@acgoldsmith acgoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I left one optional suggestion, doesn't impact approval. Great job pulling this together!

app/_src/deck/guides/konnect.md Show resolved Hide resolved
@cloudjumpercat
Copy link
Contributor Author

@smritikjaggi This is ready for you to merge once multi-geo goes GA! Let me know if you have any questions :)

@cloudjumpercat cloudjumpercat added pending:release Waiting for the PM to merge and removed do not merge Issues/ PRs whose changes should not be merged at this time labels Nov 20, 2023
@smritikjaggi smritikjaggi merged commit 6f87b78 into main Nov 21, 2023
25 of 26 checks passed
@smritikjaggi smritikjaggi deleted the feat/multi-geo-ga branch November 21, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending:release Waiting for the PM to merge review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants